add useExistingRole support. #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KlavsKlavsen |
Done :) |
|
@KlavsKlavsen |
Signed-off-by: Klavs Klavsen <klavs.klavsen@bec.dk>
|
rebased again :) |
zanhsieh
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This add useExistingRole option, which enables chart to skip role creation and instead bind to existing role - which is needed in f.ex. some RHEL openshift+jenkins setups, where "normal users" are not allowed to create role's (but can do the rolebinding and sa creation to the existing role).
Checklist
x DCO signed
x Chart Version bumped
x Variables are documented in the README.md
helm/charts#23370 - reimplementation in new repo as requested.
Same option is in among others - Prometheus (upstreamed by me :)